-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
修复长时间运行时 Redis 命令中断导致 accessToken 刷新失败的问题 #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
develop
Choose a base branch
from
copilot/fix-access-token-concurrency-issue
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+284
−7
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e9df9c
Initial plan
Copilot e50d1c2
修复 Redis 命令被中断时的 accessToken 异常问题
Copilot 0c6aa69
Potential fix for pull request finding
binarywang e9ac624
Potential fix for pull request finding
binarywang 8ec7cb8
Potential fix for pull request finding
binarywang 96f8684
Potential fix for pull request finding
binarywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
.../me/chanjar/weixin/common/util/locks/RedisTemplateSimpleDistributedLockInterruptTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| package me.chanjar.weixin.common.util.locks; | ||
|
|
||
| import org.mockito.Mockito; | ||
| import org.springframework.data.redis.core.StringRedisTemplate; | ||
| import org.springframework.data.redis.core.ValueOperations; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| /** | ||
| * 测试 RedisTemplateSimpleDistributedLock 的线程中断处理行为 | ||
| * | ||
| * @author GitHub Copilot | ||
| */ | ||
| public class RedisTemplateSimpleDistributedLockInterruptTest { | ||
|
|
||
| private StringRedisTemplate mockRedisTemplate; | ||
| private ValueOperations<String, String> mockValueOps; | ||
| private RedisTemplateSimpleDistributedLock lock; | ||
|
|
||
| @BeforeMethod | ||
| @SuppressWarnings("unchecked") | ||
| public void setUp() { | ||
| mockRedisTemplate = Mockito.mock(StringRedisTemplate.class); | ||
| mockValueOps = Mockito.mock(ValueOperations.class); | ||
| Mockito.when(mockRedisTemplate.opsForValue()).thenReturn(mockValueOps); | ||
| lock = new RedisTemplateSimpleDistributedLock(mockRedisTemplate, "test_interrupt_lock", 60000); | ||
| } | ||
|
|
||
| /** | ||
| * 测试 lock() 在 Thread.sleep 被中断时应恢复线程中断标志 | ||
| * <p> | ||
| * 修复前:InterruptedException 被忽略(// Ignore),线程中断标志丢失 | ||
| * 修复后:调用 Thread.currentThread().interrupt() 恢复中断标志 | ||
| * </p> | ||
| */ | ||
| @Test(description = "lock() 方法在中断时应恢复线程中断标志") | ||
| public void testLockRestoresInterruptedFlagAfterSleepInterruption() throws InterruptedException { | ||
| AtomicBoolean interruptedFlagAfterLock = new AtomicBoolean(false); | ||
|
|
||
| // 第一次 setIfAbsent 返回 false(模拟锁被占用),第二次返回 true(模拟锁释放) | ||
| Mockito.when(mockValueOps.setIfAbsent(Mockito.anyString(), Mockito.anyString(), | ||
| Mockito.anyLong(), Mockito.any(TimeUnit.class))) | ||
| .thenReturn(false) | ||
| .thenReturn(true); | ||
| // get() 返回不同的值,确保不走可重入路径 | ||
| Mockito.when(mockValueOps.get(Mockito.anyString())).thenReturn("other-value"); | ||
|
|
||
| Thread testThread = new Thread(() -> { | ||
| // 设置中断标志 | ||
| Thread.currentThread().interrupt(); | ||
| // 调用 lock(),第一次 tryLock 失败,sleep 会因中断标志立即抛出 InterruptedException | ||
| lock.lock(); | ||
| interruptedFlagAfterLock.set(Thread.currentThread().isInterrupted()); | ||
| }); | ||
|
|
||
| testThread.start(); | ||
| testThread.join(5000); | ||
|
|
||
| // 线程应该已经完成(不会永远阻塞) | ||
| Assert.assertFalse(testThread.isAlive(), "线程应该已完成"); | ||
| // 关键验证:中断标志应被恢复(而非被忽略丢失) | ||
| Assert.assertTrue(interruptedFlagAfterLock.get(), "lock()执行后线程中断标志应被恢复"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试 tryLock() 在 Redis 正常响应时的基本行为 | ||
| */ | ||
| @Test(description = "tryLock() 成功获取锁时应返回 true") | ||
| public void testTryLockSuccessfully() { | ||
| Mockito.when(mockValueOps.setIfAbsent(Mockito.anyString(), Mockito.anyString(), | ||
| Mockito.anyLong(), Mockito.any(TimeUnit.class))) | ||
| .thenReturn(true); | ||
|
|
||
| boolean result = lock.tryLock(); | ||
|
|
||
| Assert.assertTrue(result, "应成功获取锁"); | ||
| Assert.assertNotNull(lock.getLockSecretValue(), "锁值不应为null"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试 tryLock() 在锁已被其他线程持有时应返回 false | ||
| */ | ||
| @Test(description = "锁被占用时 tryLock() 应返回 false") | ||
| public void testTryLockWhenLockHeld() { | ||
| Mockito.when(mockValueOps.setIfAbsent(Mockito.anyString(), Mockito.anyString(), | ||
| Mockito.anyLong(), Mockito.any(TimeUnit.class))) | ||
| .thenReturn(false); | ||
| Mockito.when(mockValueOps.get(Mockito.anyString())).thenReturn("other-lock-value"); | ||
|
|
||
| boolean result = lock.tryLock(); | ||
|
|
||
| Assert.assertFalse(result, "锁被占用时应返回false"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 136 additions & 0 deletions
136
...-cp/src/test/java/me/chanjar/weixin/cp/config/impl/AbstractWxCpInRedisConfigImplTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| package me.chanjar.weixin.cp.config.impl; | ||
|
|
||
| import me.chanjar.weixin.common.redis.WxRedisOps; | ||
| import org.mockito.Mockito; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.concurrent.locks.Lock; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
|
|
||
| /** | ||
| * 测试 AbstractWxCpInRedisConfigImpl 对 Redis 异常的容错处理 | ||
| * | ||
| * @author GitHub Copilot | ||
| */ | ||
| public class AbstractWxCpInRedisConfigImplTest { | ||
|
|
||
| private WxRedisOps mockRedisOps; | ||
| private AbstractWxCpInRedisConfigImpl config; | ||
|
|
||
| @BeforeMethod | ||
| public void setUp() { | ||
| mockRedisOps = Mockito.mock(WxRedisOps.class); | ||
| Mockito.when(mockRedisOps.getLock(Mockito.anyString())) | ||
| .thenReturn(new ReentrantLock()); | ||
|
|
||
| config = new AbstractWxCpInRedisConfigImpl(mockRedisOps, "test") { | ||
| // 使用匿名类提供具体实现用于测试 | ||
| }; | ||
| config.setCorpId("testCorpId"); | ||
| config.setAgentId(1); | ||
| } | ||
|
|
||
| /** | ||
| * 测试当 Redis getExpire 抛出异常时,isAccessTokenExpired() 应返回 true(视为已过期) | ||
| */ | ||
| @Test | ||
| public void testIsAccessTokenExpiredWhenRedisThrowsException() { | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())) | ||
| .thenThrow(new RuntimeException("Redis command interrupted")); | ||
|
|
||
| boolean expired = config.isAccessTokenExpired(); | ||
|
|
||
| Assert.assertTrue(expired, "Redis异常时应将token视为已过期"); | ||
| Assert.assertFalse(Thread.currentThread().isInterrupted(), "处理异常后线程中断标志应被清除"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试当线程中断状态已设置时,Redis 调用抛出异常,isAccessTokenExpired() 应处理并清除中断标志 | ||
| */ | ||
| @Test | ||
| public void testIsAccessTokenExpiredClearsInterruptedFlag() { | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())) | ||
| .thenThrow(new RuntimeException("Redis command interrupted")); | ||
|
|
||
| // 设置线程中断标志 | ||
| Thread.currentThread().interrupt(); | ||
| try { | ||
| boolean expired = config.isAccessTokenExpired(); | ||
|
|
||
| Assert.assertTrue(expired, "Redis异常时应将token视为已过期"); | ||
| // 中断标志应该被清除,允许后续操作正常进行 | ||
| Assert.assertFalse(Thread.currentThread().isInterrupted(), "处理异常后线程中断标志应被清除"); | ||
| } finally { | ||
| // 兜底清除当前线程的中断标志,避免影响后续测试用例 | ||
| Thread.interrupted(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * 测试正常情况下 isAccessTokenExpired() 的行为 | ||
| */ | ||
| @Test | ||
| public void testIsAccessTokenExpiredWhenTokenValid() { | ||
| // 返回60秒后过期(未过期) | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())).thenReturn(60L); | ||
|
|
||
| boolean expired = config.isAccessTokenExpired(); | ||
|
|
||
| Assert.assertFalse(expired, "token未过期时应返回false"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试 isAccessTokenExpired() 当 expire 为 null 时视为已过期 | ||
| */ | ||
| @Test | ||
| public void testIsAccessTokenExpiredWhenExpireIsNull() { | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())).thenReturn(null); | ||
|
|
||
| boolean expired = config.isAccessTokenExpired(); | ||
|
|
||
| Assert.assertTrue(expired, "expire为null时应视为已过期"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试当 Redis getExpire 抛出异常时,isJsapiTicketExpired() 应返回 true(视为已过期) | ||
| */ | ||
| @Test | ||
| public void testIsJsapiTicketExpiredWhenRedisThrowsException() { | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())) | ||
| .thenThrow(new RuntimeException("Redis command interrupted")); | ||
|
|
||
| boolean expired = config.isJsapiTicketExpired(); | ||
|
|
||
| Assert.assertTrue(expired, "Redis异常时应将jsapi_ticket视为已过期"); | ||
| Assert.assertFalse(Thread.currentThread().isInterrupted(), "处理异常后线程中断标志应被清除"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试当 Redis getExpire 抛出异常时,isAgentJsapiTicketExpired() 应返回 true(视为已过期) | ||
| */ | ||
| @Test | ||
| public void testIsAgentJsapiTicketExpiredWhenRedisThrowsException() { | ||
| Mockito.when(mockRedisOps.getExpire(Mockito.anyString())) | ||
| .thenThrow(new RuntimeException("Redis command interrupted")); | ||
|
|
||
| boolean expired = config.isAgentJsapiTicketExpired(); | ||
|
|
||
| Assert.assertTrue(expired, "Redis异常时应将agent_jsapi_ticket视为已过期"); | ||
| Assert.assertFalse(Thread.currentThread().isInterrupted(), "处理异常后线程中断标志应被清除"); | ||
| } | ||
|
|
||
| /** | ||
| * 测试提供自定义 Lock 实现时 getAccessTokenLock() 返回正确的锁 | ||
| */ | ||
| @Test | ||
| public void testGetAccessTokenLockReturnsMockedLock() { | ||
| Lock mockLock = Mockito.mock(Lock.class); | ||
| Mockito.when(mockRedisOps.getLock(Mockito.anyString())).thenReturn(mockLock); | ||
|
|
||
| Lock lock = config.getAccessTokenLock(); | ||
|
|
||
| Assert.assertNotNull(lock, "获取到的锁不应为null"); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.warn目前只记录了e.getMessage(),会丢失堆栈与根因类型信息,后续排查 Redis 中断/连接问题可能不够。建议确认是否需要保留异常对象信息以便定位。Severity: low
Other Locations
weixin-java-cp/src/main/java/me/chanjar/weixin/cp/config/impl/AbstractWxCpInRedisConfigImpl.java:162weixin-java-cp/src/main/java/me/chanjar/weixin/cp/config/impl/AbstractWxCpInRedisConfigImpl.java:199🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.