fix(watcher): skip project root when watching files-source dirs#458
Draft
fix(watcher): skip project root when watching files-source dirs#458
Conversation
Avoid adding the project root to focusWatched when a files-source entry lives at the root level. The project root is already shallow-watched by Start(); adding it to focusWatched caused removeFocusWatches to drop that baseline watch, breaking auto-detect rescans for new source directories. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
watchProjectSourcescould add the project root tofocusWatchedwhen atype:"files"source has a root-level file (e.g.README.md)filepath.Dir(f)resolves to the project root, which is already shallow-watched byStart()— adding it tofocusWatchedcausesremoveFocusWatchesto drop that baseline watch, breaking auto-detect for new source directories until server restart🤖 Generated with Claude Code