feat: add full-featured repo configuration modal and extract RepoConfigForm#474
feat: add full-featured repo configuration modal and extract RepoConfigForm#474
Conversation
Extracts repo search, selected repo display, recent repos list, subpath input, and branch/PR picker into a reusable RepoConfigForm component. Also adds excludeRepos filtering support to RepoSearchInput. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ProjectSection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No remaining consumers after ProjectSection was updated to use AddRepoModal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matt2e
force-pushed
the
full-featured-add-repo
branch
from
a45fe0e to
a914af1
Compare
![chatgpt-codex-connector[bot]](https://avatars.gh.lumenfield.work/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a914af1d71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const normalizedSubpath = subpath.trim().replace(/^\/+|\/+$/g, '') || undefined; | ||
| const normalizedBranch = branchName.trim() || undefined; | ||
| const prNumber = matchedPr?.number ?? undefined; |
There was a problem hiding this comment.
When a user pastes a PR URL, RepoConfigForm initially stores that PR as pending state until BranchPicker finishes loading, but handleAdd only reads matchedPr and branchName. If the user clicks Add Repository before that async hydration completes (or if PR fetch fails), this submits with neither prNumber nor the PR head branch, so add_project_repo falls back to an inferred branch name instead of the intended PR branch. This is a functional regression from the previous picker flow, which forwarded the PR number immediately.
Useful? React with 👍 / 👎.
1 participant
Summary
RepoConfigFormcomponent fromNewProjectFormto enable reuse across project creation and repo addition flowsAddRepoModalwith full repo configuration (branch, path filters, file size limit) for adding repos to existing projectsGitHubRepoPickerdropdown inProjectSectionwith the newAddRepoModalGitHubRepoPickercomponentTest plan
RepoConfigFormAddRepoModalwith all configuration optionsGitHubRepoPickeris no longer referenced anywhere🤖 Generated with Claude Code