fix: close pipe fds in parent to prevent deadlock when child exits#228
Merged
alecthomas merged 1 commit intomainfrom Mar 26, 2026
Merged
fix: close pipe fds in parent to prevent deadlock when child exits#228alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
StdoutPipe() retains the pipe read end in the parent until Wait() runs closeAfterWait. If the downstream process exits early, the upstream cannot receive SIGPIPE (parent still holds the read end), so it blocks on pipe write and Wait() deadlocks. Replace StdoutPipe() with manual os.Pipe() in Create, StreamTo, and Extract, closing both ends in the parent immediately after starting child processes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StdoutPipe() retains the pipe read end in the parent until Wait() runs
closeAfterWait. If the downstream process exits early, the upstream
cannot receive SIGPIPE (parent still holds the read end), so it blocks
on pipe write and Wait() deadlocks.
Replace StdoutPipe() with manual os.Pipe() in Create, StreamTo, and
Extract, closing both ends in the parent immediately after starting
child processes.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com