Testing: Improve test coverage for error paths and edge cases

[leogdion]

Overview

Improve test coverage identified as missing during PR #134 review, focusing on error paths, edge cases, and integration tests.

Missing Test Coverage

1. Error Path Testing

Areas needing tests:

• Invalid field value conversions (e.g., accessing .stringValue on an .int64 case)
• Edge cases like empty filter arrays
• Boundary conditions for dates and numeric values
• Integer overflow scenarios
• Invalid field name handling

Example test cases needed:

@Test func testInvalidFieldValueConversion() {
  let intValue = FieldValue.int64(42)
  #expect(throws: FieldValueError.wrongType) {
    _ = try intValue.stringValue()
  }
}

@Test func testDateBoundaryConditions() {
  // Test very distant past/future dates
  // Test Date.distantPast and Date.distantFuture
}

@Test func testEmptyFilterArray() {
  // Verify behavior with empty filter lists
}

2. Integration Tests

Needed:

• End-to-end filter construction and query building
• Mock network layer testing with actual CloudKit query payloads
• Filter serialization/deserialization round-trip tests

3. Celestra Example Testing

Location: Examples/Celestra/

Missing tests for:

• RateLimiter.swift - Rate limiting logic
• RobotsTxtService.swift - Robots.txt parsing
• RSSFetcherService.swift - RSS feed fetching
• Other service implementations

Priority areas:

// RateLimiter edge cases
@Test func testRateLimiterConcurrency()
@Test func testRateLimiterBurstHandling()

// RobotsTxtService edge cases  
@Test func testRobotsTxtMalformedInput()
@Test func testRobotsTxtNetworkFailure()

// RSSFetcherService edge cases
@Test func testRSSFetcherInvalidFeed()
@Test func testRSSFetcherTimeout()

Benefits

• Catch bugs before they reach production
• Document expected behavior through tests
• Ensure error handling works correctly
• Validate edge case handling
• Improve code reliability

Related

• PR Adding Celestra to Demos #134

Labels

testing, quality-assurance