Skip to content

fix(tape): align tape.search match count with output#138

Merged
frostming merged 2 commits intobubbuild:mainfrom
Andy963:fix/tape-search-match-count
Mar 30, 2026
Merged

fix(tape): align tape.search match count with output#138
frostming merged 2 commits intobubbuild:mainfrom
Andy963:fix/tape-search-match-count

Conversation

@Andy963
Copy link
Copy Markdown
Contributor

@Andy963 Andy963 commented Mar 29, 2026

Summary

Fix tape.search output so the reported match count reflects the entries actually
shown after filtering internal tape.search echoes.

This also makes the filtered count explicit even when it is zero.

Changes

  • report shown matches with len(lines) instead of raw len(entries)
  • report filtered entries as len(entries) - len(lines)
  • add focused tests for:
    • filtered entries are counted correctly
    • 0 filtered is shown explicitly

Testing

uv run pytest -q tests/test_tape_search_output.py

@frostming frostming merged commit 212aab8 into bubbuild:main Mar 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants