Conversation
PR #45 changed the get-tree IPC response from a flat array to { nodes, totalCount }, but browser.test.ts was not updated to match, causing the release workflow to fail on every push to main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-treeIPC response from a flat array to{ nodes, totalCount }, butbrowser.test.tswas not updated to matchTypeError: actual value must be number or bigint, received "undefined"atbrowser.test.ts:75Why the PR didn't catch it
The
ci.ymlworkflow (which runs on PRs) does not include browser E2E tests — they only run inrelease.ymlon push to main, so the regression slipped through.Test plan
E2E tests (browser)passes on merge🤖 Generated with Claude Code