Draft
Conversation
192e676 to
4cae176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile slow/profile rerendersoutputWhat changed
profile reportinstance-specific, but showpathandsrcwhen availableprofile report,profile slow, andprofile rerenders--limitbehavior stable after grouping by enriching a bounded candidate window and trimming at format timeWhy
This addresses feedback from #54 about profiling output being hard to interpret when many repeated rows appear, especially
Context.Provider-style entries with no useful grouping or hierarchy context.Limitation
This PR uses the best identity the current backend exposes: normalized source metadata from
inspectElement.That means grouping is conservative and practical, but it is not a true runtime implementation id. We are doing the best we can without backend support for a stable component implementation identifier.
Validation
pnpm --filter agent-react-devtools testpnpm --filter agent-react-devtools typecheck