Added event types and minor improvements to executor#639
Merged
joeyballentine merged 3 commits intochaiNNer-org:mainfrom Jul 27, 2022
Merged
Added event types and minor improvements to executor#639joeyballentine merged 3 commits intochaiNNer-org:mainfrom
joeyballentine merged 3 commits intochaiNNer-org:mainfrom
Conversation
Member
Author
|
|
joeyballentine
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third time I wanted to implement parallelism for broadcast data, but ended up doing refactoring instead...
Well, this time around, I did some minor refactoring around
ExecutorandExecutorContext, I added anAppContextclass to strictly typeapp.ctxinrun.py, and I completely typed server-sent events on the python side (I also found and fixed a small and inconsequential error in the TS types for events).