Skip to content

fix(localizations): correct username placeholder in en-GB#8040

Open
petiteoh wants to merge 2 commits intomainfrom
fix/en-gb-username-placeholder
Open

fix(localizations): correct username placeholder in en-GB#8040
petiteoh wants to merge 2 commits intomainfrom
fix/en-gb-username-placeholder

Conversation

@petiteoh
Copy link
Contributor

@petiteoh petiteoh commented Mar 11, 2026

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Fixed British English text so the username input now shows the placeholder "Enter your username" instead of a missing/undefined value, improving clarity during login.
  • Chores
    • Added a patch changeset to publish the localization fix.

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 11, 2026 2:29pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8040

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8040

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8040

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8040

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8040

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8040

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8040

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8040

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8040

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8040

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8040

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8040

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8040

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8040

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8040

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8040

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8040

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8040

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8040

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8040

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8040

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8040

commit: 607ee1e

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2b081ba3-555b-4ecc-a0a1-dc8f2741e68b

📥 Commits

Reviewing files that changed from the base of the PR and between b6f9688 and 607ee1e.

📒 Files selected for processing (1)
  • .changeset/fix-en-gb-username-placeholder.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/fix-en-gb-username-placeholder.md

📝 Walkthrough

Walkthrough

The en-GB localization was updated to set the formFieldInputPlaceholder__username key to "Enter your username" (it was previously undefined). A new changeset file was added at .changeset/fix-en-gb-username-placeholder.md indicating a patch release for the package and describing the fix.

Possibly related PRs

  • clerk/javascript PR 8002 — Adds the same formFieldInputPlaceholder__username localization string to the en-US locale file.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the username placeholder in the en-GB localization file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

🦋 Changeset detected

Latest commit: 607ee1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/localizations Patch
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

"@clerk/localizations": patch
---

Fix en-GB username field placeholder (was showing literal "undefined" instead of "Enter your username")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically undefined is not literal "undefined" but this is not a blocker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants