You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's the TLDR of what this does and how much it improves performance?
@irvinebroque This particular change enables on-demand compile cache for built-in modules (such as node:buffer, node:url etc.). Simplify, the second import of a built-in module becomes extremely cheap, and hence improves the boot time (due to the less time required to parse and analyze the module). This is particularly different than Node.js, since Node compiles all built-in modules on compile time, which makes the first import extremely cheap. I haven't done any benchmarks yet, but Node.js has seen 56% improvement in boot time by implementing the whole build time caching. (Ref: nodejs/node#24950). We can invest on this and go through a similar path depending on the nodejs_compat flags for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables compile cache in workerd.