Skip to content

Correct _load_textdomain_just_in_time PHP notices #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aatanasov-cloudinary merged 4 commits into from
May 23, 2025
Merged

Correct _load_textdomain_just_in_time PHP notices #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfaef6e
Prepare init hooks
aatanasovdev May 19, 2025
cd190e5
Adjust the cloudinary_version_upgrade hook position
aatanasovdev May 19, 2025
8457ece
Move register_handlers outside of init
aatanasovdev May 23, 2025
feeb23a
Format code
aatanasovdev May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,18 @@ class Media extends Settings_Component implements Setup {
public function __construct( Plugin $plugin ) {
$this->plugin = $plugin;

add_action( 'init', array( $this, 'init_hook' ) );

// Add upgrade hook, since setup methods are called after the connect upgrade has run.
add_action( 'cloudinary_version_upgrade', array( $this, 'upgrade_media_settings' ) );
}

/**
* Initialize WordPress hooks for the Cloudinary media integration.
*
* @return void
*/
public function init_hook() {
/**
* Filter the Cloudinary Media Library filters.
*
Expand All @@ -173,9 +185,6 @@ public function __construct( Plugin $plugin ) {
SYNC::META_KEYS['unsynced'] => __( 'Unsynced', 'cloudinary' ),
)
);

// Add upgrade hook, since setup methods are called after the connect upgrade has run.
add_action( 'cloudinary_version_upgrade', array( $this, 'upgrade_media_settings' ) );
}

/**
Expand Down
13 changes: 12 additions & 1 deletion php/class-meta-box.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,21 @@ class Meta_Box {
*/
public function __construct( Plugin $plugin ) {
$this->plugin = $plugin;
add_action( 'add_meta_boxes', array( $this, 'register_meta_box' ) );

add_action( 'init', array( $this, 'init_hook' ) );

$this->register_handlers();
}

/**
* Initialize hooks for the meta box.
*
* @return void
*/
public function init_hook() {
add_action( 'add_meta_boxes', array( $this, 'register_meta_box' ) );
}

/**
* Register meta box for image sizes.
*/
Expand Down