Conversation
| transform: scale(1.5); | ||
| transform-origin: center; |
There was a problem hiding this comment.
A teensy bit hacky -- the whole site was really small and a bump up in scaling makes it look much nicer.
An important note from MDN on zoom vs. transform:
[zoom CSS property] is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.
Note that it's not supported in Firefox either due to it not being in the CSS standard, which is why I used transform.
|
✔️ Deploy Preview for infallible-lumiere-e9d357 ready! 🔨 Explore the source changes: adeed84 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-lumiere-e9d357/deploys/60da88baa8c51500079e8973 😎 Browse the preview: https://deploy-preview-1201--infallible-lumiere-e9d357.netlify.app/ |
|
When you take the keyboard out on android for the footer follows the keyboard up and overlaps the images on smaller screens (photo from base S21) for large screen phones it stays below the images and is fine. The brick hack logo also gets cut off the page on smaller screen phones |
|
On IOS the logos have no margin and are all right next to each other and the windows 95 text box. |
|
Just a thought and you can ignore it but have the maximize button cause the browser to go into/out of full screen mode. |
skyegallup
left a comment
skyegallup
left a comment
There was a problem hiding this comment.
I really like the site! There's a few code style issues that should get fixed, however.
Also, I can confirm that the clipping issue @JeremyRudman pointed out above also show up on my mobile device (Galaxy S8, Firefox 89) when I open my keyboard to add my email. The button spacing works fine on my device, though.
I think this is because we're using the |
Notable is the height constraint added tot he media query, and width->max-width to allow for better mobile resizing
Normally i'd use a % but window glitches when too small and imo cutoff is better
| </div> | ||
| </section> | ||
| <footer> | ||
| <p>Interested in sponsoring? <span class="text-break">E-mail <a href="mailto:sponsorship@coderit.org">sponsorship@coderit.org</a></span></p> |
There was a problem hiding this comment.
This should be using a brickhack.io email instead of a coderit.org one, if at all possible.
Co-authored-by: Claire Gallup <colbygallup@gmail.com>
Co-authored-by: Claire Gallup <colbygallup@gmail.com>
Co-authored-by: Claire Gallup <colbygallup@gmail.com>
Co-authored-by: Claire Gallup <colbygallup@gmail.com>
Co-authored-by: Claire Gallup <colbygallup@gmail.com>
4 participants
Background
Implements #1200
This hints at the windows 95-style retro look for the full BH8 website.
Textbox functionality will be added in next PR!
Preview