fix: URI::getSegment() returns non-existent segment#7249
Closed
kenjis wants to merge 4 commits intocodeigniter4:4.4from
Closed
fix: URI::getSegment() returns non-existent segment#7249kenjis wants to merge 4 commits intocodeigniter4:4.4from
kenjis wants to merge 4 commits intocodeigniter4:4.4from
Conversation
kenjis
added
bug
This was referenced Feb 14, 2023
Member
|
Sorry, by accident I wrote the comment under the issue report: #7246 (comment) |
4 tasks
MGatner
approved these changes
Feb 15, 2023
Member
Author
|
Since michalsn is opposed, this PR is put on hold. |
Member
|
I was pointing out the potential problem that this change brings. If everyone wants to treat it as a bug, I'm fine with that. In my opinion, it will be a bit controversial, but we have already made bigger BC changes in the past. |
Member
Author
|
I am going to withdraw this BC as it does not seem to be worth much. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7246 (and #2962)
Checklist: