Skip to content

Changes default behaviour to ignore archived and deleted repos#1743

Merged
schneems merged 7 commits intocodetriage:mainfrom
hbontempo-br:feature/ignore-deleted-archived-repos
Oct 28, 2023
Merged

Changes default behaviour to ignore archived and deleted repos#1743
schneems merged 7 commits intocodetriage:mainfrom
hbontempo-br:feature/ignore-deleted-archived-repos

Conversation

@hbontempo-br
Copy link
Copy Markdown
Contributor

Description

Changes default behavior of ReposModel to deleted and archived repos.
This repos are going to remain on database but should be ignored everywhere in the application

Related Issue

Related to #1704
Should deal with #1735 / #1545

Motivation and Context

Should prevent "bad" repos to be presented to users

How Has This Been Tested?

Automated tests + rubocop analysis (locally)

Screenshots (if appropriate):

--

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Member

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change out default_scope for something else.

@hbontempo-br
Copy link
Copy Markdown
Contributor Author

PR ended up being bigger than originally expected.
Could break up into smaller ones if you prefer.

@schneems
Copy link
Copy Markdown
Member

Thanks for working on this. Sorry for the EXTREME delay. Looks great. I corrected a merge conflict. re-running tests now.

@sanki92
Copy link
Copy Markdown

sanki92 commented Jul 17, 2025

Just signed up recently and noticed I’m still seeing archived repos (like nextcloud/gallery) in the repo list.

image

I saw #1743 was merged to handle this awesome work but looks like archived repos that were added before that fix are still being shown?

Is a one-time cleanup planned or would a script to flag/remove old archived ones be helpful? Happy to test if needed.

Thanks again for the platform, super useful otherwise!

@typenoob
Copy link
Copy Markdown

Is a one-time cleanup planned or would a script to flag/remove old archived ones be helpful? Happy to test if needed.

Thanks again for the platform, super useful otherwise!

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants