Merged
Conversation
These are meant to be the interface that users will have to use - I tried to copy as much useful documentation from the temporal grpc api as I could
jeffschoner
reviewed
Dec 19, 2023
Comment on lines
+33
to
+41
| # DO NOT MERGE THIS UPSTREAM TO COINBASE | ||
| it 'exemptions' do | ||
| data = '{"name":"foo"}' | ||
| Temporal::Connection::Converter::Payload::ProtoJSON::SPECIAL_STRIPE_WORKFLOW_PAYLOAD_TYPES.each do |message_type| | ||
| fake_payload = Struct.new(:metadata, :data).new({ 'messageType' => message_type }, data) | ||
| data_out = subject.from_payload(fake_payload) | ||
| expect(data_out).to eq({ 'name' => 'foo' }) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
@dhruv-stripe These lines from Stripe's fork leaked through in your merge and are causing CI to fail
jeffschoner
reviewed
Dec 19, 2023
spec/unit/lib/temporal/connection/converter/payload/proto_json_spec.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Schoner <jeffschoner@gmail.com>
DeRauk
approved these changes
Jan 4, 2024
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for interacting with the Temporal Schedules Api. We're using this patch internally to synchronize schedules with Temporal when new code is deployed.
The approach I took was to define a set of
Temporal::Scheduleclasses that roughly map to the proto models defined in the temporal api.This is a large PR given the surface area of the api, but I've tried to break it by commit to make it a bit easier to review.
Test Plan
Ran
rspec specandcd examples && rspec specwithout error