Skip to content

test(git): add tests for get_filenames_in_commit with git_reference #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HankyStyle wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test(git): add tests for get_filenames_in_commit with git_reference #1890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926911d
test(git): add tests for get_filenames_in_commit with git_reference
HankyStyle Mar 8, 2026
3a25dfc
test(git): address review feedback for get_filenames_in_commit tests
HankyStyle Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,34 @@ def test_commit_with_spaces_in_path(
mock_unlink.assert_called_once_with(file_path)


@pytest.mark.usefixtures("tmp_commitizen_project")
def test_get_filenames_in_commit(util: UtilFixture):
"""Test get_filenames_in_commit returns filenames from the last commit."""
util.create_file_and_commit("feat: old feature", filename="old_file.txt")
Copy link
Contributor Author

@HankyStyle HankyStyle Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a prior commit in here so we can validate that the function only returns files from the last commit.


filename = "test_feature_file.txt"
util.create_file_and_commit("feat: add new feature", filename=filename)

filenames = git.get_filenames_in_commit()
assert [filename] == filenames


@pytest.mark.usefixtures("tmp_commitizen_project")
def test_get_filenames_in_commit_with_git_reference(util: UtilFixture):
"""Test get_filenames_in_commit with a specific git reference (commit SHA)."""
first_filename = "first_feature.txt"
util.create_file_and_commit("feat: first feature", filename=first_filename)
first_commit_rev = cmd.run("git rev-parse HEAD").out.strip()

second_filename = "second_feature.txt"
util.create_file_and_commit("feat: second feature", filename=second_filename)

# Query the first commit by its SHA
filenames = git.get_filenames_in_commit(git_reference=first_commit_rev)
assert first_filename in filenames
assert second_filename not in filenames


def test_get_filenames_in_commit_error(util: UtilFixture):
"""Test that GitCommandError is raised when git command fails."""
util.mock_cmd(err="fatal: bad object HEAD", return_code=1)
Expand Down
Loading