Add option for stripping unsafe URLs#161
Merged
robinst merged 5 commits intocommonmark:masterfrom Jan 20, 2020
Merged
Conversation
robinst
requested changes
Jan 14, 2020
Collaborator
robinst
left a comment
robinst
left a comment
There was a problem hiding this comment.
Thanks! Looks pretty good already. I just have some naming and style comments, otherwise looks good.
Also, unless you have already, can you sign the CLA?: https://github.com/atlassian/commonmark-java/blob/master/CONTRIBUTING.md#cla
commonmark/src/main/java/org/commonmark/renderer/html/HtmlNodeRendererContext.java
Outdated
Show resolved
Hide resolved
commonmark/src/main/java/org/commonmark/renderer/html/DefaultUrlSanitizer.java
Outdated
Show resolved
Hide resolved
commonmark/src/main/java/org/commonmark/renderer/html/DefaultUrlSanitizer.java
Outdated
Show resolved
Hide resolved
commonmark/src/main/java/org/commonmark/renderer/html/DefaultUrlSanitizer.java
Outdated
Show resolved
Hide resolved
commonmark/src/main/java/org/commonmark/renderer/html/CoreHtmlNodeRenderer.java
Outdated
Show resolved
Hide resolved
commonmark/src/main/java/org/commonmark/renderer/html/DefaultUrlSanitizer.java
Outdated
Show resolved
Hide resolved
robinst
requested changes
Jan 15, 2020
Collaborator
robinst
left a comment
robinst
left a comment
There was a problem hiding this comment.
Ok, found one more thing, other than that this looks ready to merge :).
commonmark/src/main/java/org/commonmark/renderer/html/CoreHtmlNodeRenderer.java
Show resolved
Hide resolved
Collaborator
|
Thanks for the contribution! ❤️ I'll also add a note to the readme about this option, and then do a release sometime this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155