Open
Conversation
Signed-off-by: GerkinDev <alexandre.j.p.germain@gmail.com>
GerkinDev
commented
Jan 26, 2026
| if m.group("err") is not None: | ||
| raise RuntimeError(m.group("err")) | ||
| return m.group("default") or "" | ||
| raise RuntimeError(rec_subs(m.group("err"), subs_dict)) |
Signed-off-by: GerkinDev <alexandre.j.p.germain@gmail.com>
GerkinDev
force-pushed
the
feat/nested-env-defaults
branch
from
dcae156 to
97b7556
Compare
Author
|
While testing, I saw that some case were incorrect (for example: |
p12tic
reviewed
Feb 21, 2026
| (?:{ | ||
| (?P<braced>[_a-zA-Z][_a-zA-Z0-9]*) | ||
| (?:(?P<empty>:)?(?: | ||
| (?:-(?P<default>[^}]*)) | |
Collaborator
There was a problem hiding this comment.
I think it's bad idea to allow this to match closing '}'.
We should do something like running the replacement algorithm multiple times.
Author
There was a problem hiding this comment.
Yeah I went this direction afterwards, this is still very much a work in progress.
p12tic
requested changes
Feb 22, 2026
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Marking as "request changes" for myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for nested env var interpolation