Add environment variables interpolation#1390
Add environment variables interpolation#1390antonpetrov145 wants to merge 2 commits intocontainers:mainfrom
Conversation
|
Tests are broken. |
|
@p12tic seems the tests are passing now, what got me confused are these lines when we have the now I set the interpolation to be done directly on the |
|
Seems that the PR is still incomplete because 2 lines above we have Also, it would be great to have integration tests that show in a reproducible way what exactly didn't work before and is now fixed. |
p12tic
left a comment
There was a problem hiding this comment.
Marking as "request changes" for myself
|
@p12tic you mean the lines above what I added right, I left those as they are because then here and my change just interpolates the variables in the final object so there are no variables like tell me if this logic is not correct, if I move the line above where we have the first assign, we will have the same result as now - variables are not interpolated because they are stored like that in |
Added the existing functionality to interpolate the environment set in compose.
Refers to 1384