fix: local config — toolOverrides, config name, agent refresh#11067
Open
shanevcantwell wants to merge 3 commits intocontinuedev:mainfrom
Open
fix: local config — toolOverrides, config name, agent refresh#11067shanevcantwell wants to merge 3 commits intocontinuedev:mainfrom
shanevcantwell wants to merge 3 commits intocontinuedev:mainfrom
Conversation
Three fixes discovered during local model testing (LM Studio + config.yaml on Windows/WSL). All affect the non-cloud codepath that hasn't been tested as a cohesive surface. Fix continuedev#11060: toolOverrides (continuedev#9314) not applied in system message tools path - Add toolOverrides to ModelDescription type and serialization - Apply overrides in streamNormalInput.ts for both native and system message tools paths - Fall through description override to systemMessageDescription.prefix so the intuitive YAML field works for built-in tools Fix continuedev#11061: "Local Config" display name ignores config.yaml name field - Read primary config file in LocalProfileLoader constructor - Parse name field, fallback to "Local Config" on missing/broken file Fix continuedev#11062: New agent files don't appear immediately - config/newAssistantFile handler called reloadConfig (current profile only) instead of refreshAll (rebuilds profile list including new files) 30 tests across 4 new test files, all passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="core/config/profile/LocalProfileLoader.ts">
<violation number="1" location="core/config/profile/LocalProfileLoader.ts:61">
P2: Default profile title can become undefined when config.yaml has no name field, violating ProfileDescription contract (title: string)</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
ModelRole is re-imported but not re-exported from core/index.d.ts under tsconfig.npm.json, causing TS2459 in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply cubic-dev-ai suggestion: guard against undefined parsed.name when config.yaml has no name field. Run prettier on all changed files to fix CI prettier-check failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes discovered during local model testing (LM Studio +
config.yamlon Windows/WSL). All affect the non-cloud codepath — local models, custom configs, system message tools — that hasn't been tested as a cohesive surface.toolOverrides(feat: add tool prompt override support in .continuerc.json #9314) not applied in system message tools path — overrides were serialized incompletely and never wired intostreamNormalInput.tsfor models using system message tools instead of native tool callingconfig.yamlnamefield —LocalProfileLoaderhardcoded the title for the default profile instead of reading it from the config fileconfig/newAssistantFilehandler calledreloadConfig(current profile only) instead ofrefreshAll(rebuilds profile list)Context
PR #9314 added
toolOverridesto let users customize tool descriptions and disable tools per-model. It worked for models using the native tools API, but the system message tools path (used by local models withcapabilities: []) was never wired up. The serialization gap meanttoolOverridesnever reached the GUI's Redux store, andstreamNormalInput.tspassed rawselectActiveTools()output directly to the system message builder without applying overrides.The other two bugs (config name, agent refresh) were found during the same testing session and affect the same local config surface.
Changes
core/index.d.tstoolOverrides?: ToolOverride[]toModelDescriptioncore/config/load.tstoolOverridesinllmToSerializedModelDescription()gui/src/redux/thunks/streamNormalInput.tsapplyToolOverridesfor both native and system message tools pathscore/tools/applyToolOverrides.tsdescriptionoverride tosystemMessageDescription.prefixfor built-in toolscore/config/profile/LocalProfileLoader.tsnamefrom primary config file in constructorcore/core.tsreloadConfig→refreshAllinconfig/newAssistantFilehandlerTest plan
🤖 Generated with Claude Code
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Fixes three local-config issues: per-model toolOverrides now apply to system-message tools, the default profile uses the config.yaml name, and new agent files appear immediately. Improves the local model and custom config experience.
Written for commit a221949. Summary will update on new commits.