fix(cli): prevent empty sessions from being saved#11076
Open
uinstinct wants to merge 4 commits intocontinuedev:mainfrom
Open
fix(cli): prevent empty sessions from being saved#11076uinstinct wants to merge 4 commits intocontinuedev:mainfrom
uinstinct wants to merge 4 commits intocontinuedev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/slashCommands.ts">
<violation number="1" location="extensions/cli/src/slashCommands.ts:177">
P2: `/sessions` emits duplicate `useSlashCommand` telemetry because it is captured globally and again inside `handleSessions`.</violation>
</file>
<file name="extensions/cli/src/services/ChatHistoryService.ts">
<violation number="1" location="extensions/cli/src/services/ChatHistoryService.ts:83">
P2: Unsafe optional chaining in initialization log can throw when `session` exists but `history` is missing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| } | ||
|
|
||
| function handleSessions() { | ||
| posthogService.capture("useSlashCommand", { name: "sessions" }); |
Contributor
There was a problem hiding this comment.
P2: /sessions emits duplicate useSlashCommand telemetry because it is captured globally and again inside handleSessions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/slashCommands.ts, line 177:
<comment>`/sessions` emits duplicate `useSlashCommand` telemetry because it is captured globally and again inside `handleSessions`.</comment>
<file context>
@@ -173,6 +173,11 @@ function handleJobs() {
}
+function handleSessions() {
+ posthogService.capture("useSlashCommand", { name: "sessions" });
+ return { openSessionSelector: true };
+}
</file context>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Empty sessions files are created in ~/.continue/sessions even when there are no user messages. This PR fixes that
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Prevents empty CLI chat sessions from being saved and adds a /sessions command to quickly view all sessions.
Bug Fixes
New Features
Written for commit 4244ee9. Summary will update on new commits.