Fix system-message tools parser when tool call is non-terminal#11092
Open
MumuTW wants to merge 5 commits intocontinuedev:mainfrom
Open
Fix system-message tools parser when tool call is non-terminal#11092MumuTW wants to merge 5 commits intocontinuedev:mainfrom
MumuTW wants to merge 5 commits intocontinuedev:mainfrom
Conversation
dosubot
bot
added
the
size:L
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.gh.lumenfield.work/in/1082092?s=60&v=4){kind=small}
MumuTW
force-pushed
the
fix-system-tools-non-terminal-11074
branch
from
15c0036 to
cc09312
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
The `as typeof X & Y` type assertion was ambiguous to the TypeScript parser without parentheses, causing TS1005 errors across all CI checks. Simplify to `as any` since this is a test assertion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When ```` ``` ```` closes a tool call, splitAtCodeblocksAndNewLines splits ```` ```\n ```` into [```` ``` ````, `\n`]. The ```` ``` ```` chunk completes the tool call and the `\n` was incorrectly emitted as a text content yield, throwing off yield counts and causing the trailing content test to see `undefined` instead of the preserved text. Skip the newline immediately following a completed tool call codeblock and fix the test loop count (4 tool deltas, not 6). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
ELIFECYCLE Command failed.
WARN Local package.json exists, but node_modules missing, did you mean to install? (fails in this workspace because is missing and is unavailable)
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Fix system-message tool-call parsing so completed calls don’t end the stream and trailing or mid-message assistant text is preserved. Also skip the stray newline after a closed tool-call codeblock, dedupe dynamic tool definitions, and map "reasoning-delta" to reasoning_content.
Written for commit b4fe40c. Summary will update on new commits.