fix: recursively convert struct to dict#73
Merged
negz merged 1 commit intocrossplane:mainfrom Aug 13, 2024
Merged
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
Contributor
Author
|
unsure about whether or not we want to keep the previous behaviour as default, while allowing a "recursive" struct_to_dict via an additional argument :/ |
Collaborator
Good question - I tend to think the existing behavior is "wrong" since I would have expected nested translation, but it could be breaking if people are already used to having to convert the child objects. I'd still lean toward changing it though. @negz any thoughts? |
negz
approved these changes
Aug 13, 2024
Member
negz
left a comment
There was a problem hiding this comment.
Yeah, I tend to agree this feels more like a bug fix. No need to maintain the old behavior. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Converting metadata struct to a dict should return a nested dict, rather than a dict with e.g. annotations as a struct.
I have: