Add strict typecheck guard for changed TypeScript files#5749
Open
rebelchris wants to merge 6 commits intomainfrom
Open
Add strict typecheck guard for changed TypeScript files#5749rebelchris wants to merge 6 commits intomainfrom
rebelchris wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
capJavert
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecheck:strict:changedscript to enforce strict TypeScript checks only for changed.tsand.tsxfiles@ts-ignoreand@ts-nocheckusage through shared ESLint config, while allowing documented@ts-expect-error@ts-ignoreusages and add supporting type declarations so touched files pass the new guardRenderMarkdownand Storybook typings to satisfy strict mode without broad suppressionsTesting
pnpm installnpm run typecheck:strict:changedpnpm --filter @dailydotdev/shared lintPreview domain
https://codex-add-tsignore-temporary-pla.preview.app.daily.dev