Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 51 51
Lines 3474 3474
=======================================
Hits 1900 1900
Misses 1434 1434
Partials 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What in particular? |
|
The setup job in this PR has been kneecapped to doing nothing and appears redundant with this changelog. I don't think any of this change (this is all linked so I don't think it's appropriate to break this down into parts). This workflow is used to build the runtime especially when implementing new building blocks, this assists in pre-release validation and demonstrability of functionality. The tests can be triggered down the line if/when a release pipeline is created with dapr builds that are unversioned. The workflows are very efficient already making use of a setup step and handling the build artifacts - steps that are ignored if no commit SHAs are provided, so I'm not really seeing the value of removing this. Could you please elaborate on reasoning for raising this? |
|
Thanks for the answer. The point of this PR is to make use of the shared actions to install the cli and the runtime, and I removed pieces that I thought were not in use, but I was clearly wrong. |
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
|
@mikeee Thoughts? I brought back the inputs to select specific commit SHA for the runtime and CLI. Also kept using |
|
If I'm reading this correctly, what you've proposed will; if given a commit - build the runtime/cli for each job? I'd honestly like to see a proposal - dapr/community#320 or a sig. |
Correct. Instead of one shared setup step, each validation step builds its own requirement. This shouldn't impact the global time, as today all vaidations are waiting for the setup to finish, and now they'll trigger sooner but each build its binaries. I can move it back to do it in the setup step, but I'm not sure it's worth the complexity, the majority of the runs of this step will just install the latest cli and runtime from the corresponding releases and won't compile anything. |
Signed-off-by: Albert Callarisa <albert@diagrid.io>
…a/dapr-go-sdk into use-shared-cli-and-runtime-actions
Uh oh!
There was an error while loading. Please reload this page.