Fix false duplicate source code path error for git-sourced apps#4996
Fix false duplicate source code path error for git-sourced apps#4996
Conversation
When multiple apps use git_source instead of source_code_path, the duplicate path check incorrectly flags them because all git-sourced apps have an empty SourceCodePath, colliding on the same map key "". Skip the duplicate check when SourceCodePath is empty. Task: 001.md Co-authored-by: Isaac
Co-authored-by: Isaac
… check Task: 002.md Co-authored-by: Isaac
Include the output of running the acceptance test against v0.296.0 (`-useversion 0.296.0`), confirming the test catches a real regression: the old CLI falsely reports "Duplicate app source code path" for git-sourced apps that have no source_code_path set. Task: 003.md Co-authored-by: Isaac
Approval status: pending
|
Changes
git_sourceinstead ofsource_code_path. The duplicate check keyed onSourceCodePath, so all git-sourced apps collided on the empty string. Now skips the check whenSourceCodePathis empty.Why
Users with multiple git-sourced apps in a bundle get a spurious validation error that blocks
bundle validateandbundle deploy.Tests
Output of
go test ./acceptance -run TestAccept/bundle/apps/git_source_no_duplicate -useversion 0.296.0:app resource 'app1' has the same source code path as app resource 'app2', this will lead to the app configuration being overriden by each other