Port PlotlyGraph from deepforge. Closes #8#9
Merged
umesh-timalsina merged 1 commit intomasterfrom Aug 20, 2020
Merged
Conversation
brollb
requested changes
Aug 20, 2020
| // Add/overwrite any additional settings here | ||
| // config.server.port = 8080; | ||
| // config.mongo.uri = 'mongodb://127.0.0.1:27017/webgme_my_app'; | ||
| config.seedProjects.basePaths = ['src/seeds/project']; |
Contributor
There was a problem hiding this comment.
why is "project" included here?
| this._widget = options.widget; | ||
|
|
||
| this._embedded = options.embedded; | ||
| this._activeNodeMetaName = options.activeNodeMetaName || GRAPH; |
Contributor
There was a problem hiding this comment.
It would be nice if we could remove this since it tightly couples the visualizer to a metamodel (and this is already implied by setting this as the visualizer for the given node).
Contributor
There was a problem hiding this comment.
That is, it should be safe to assume that this._currentNodeId corresponds to a graph node.
| 'use strict'; | ||
|
|
||
| const GRAPH = 'Graph', | ||
| DATA = 'data'; |
Contributor
There was a problem hiding this comment.
I would probably rename this to DEFAULT_DATA_ATTRIBUTE to match the terminology used (ie, plotlyDataAttribute).
umesh-timalsina
added a commit
that referenced
this pull request
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.