Skip to content

restore CSS sourcemap support #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 3 commits into from
Dec 19, 2020
Merged

restore CSS sourcemap support #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da2d838
Merge pull request #1 from developit/master
stipsan Dec 19, 2020
7d5fb92
fix: restore CSS sourcemap support
stipsan Dec 19, 2020
2be0a86
no CSS maps when inline
stipsan Dec 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@ function createConfig(options, entry, format, writeMeta) {
inject: false,
extract: options.css !== 'inline',
minimize: options.compress,
sourceMap: options.sourcemap && options.css !== 'inline',
}),
moduleAliases.length > 0 &&
alias({
Expand Down
8 changes: 6 additions & 2 deletions test/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,7 @@ Directory tree:
basic-css
dist
basic-css.css
basic-css.css.map
basic-css.esm.js
basic-css.esm.js.map
basic-css.js
Expand All @@ -454,9 +455,12 @@ Build \\"basicCss\\" to dist:
138 B: basic-css.umd.js.br"
`;

exports[`fixtures build basic-css with microbundle 2`] = `7`;
exports[`fixtures build basic-css with microbundle 2`] = `8`;

exports[`fixtures build basic-css with microbundle 3`] = `".testing{display:flex;color:red;background:#00f}"`;
exports[`fixtures build basic-css with microbundle 3`] = `
".testing{display:flex;color:red;background:#00f}
/*# sourceMappingURL=basic-css.css.map */"
`;

exports[`fixtures build basic-css with microbundle 4`] = `
"function e(){var e=document.createElement(\\"div\\");return e.className=\\"testing\\",e}export default e;
Expand Down