Skip to content

Remove all listeners when .off gets called without a type #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andarist wants to merge 2 commits into from
+25 −1
Closed

Remove all listeners when .off gets called without a type #72

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eebe2
Remove all listeners when .off gets called without a type
Andarist Jan 25, 2018
7900192
Merge branch 'master' into off-all
developit Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ export default function mitt(all: EventHandlerMap) {
* @memberOf mitt
*/
off(type: string, handler: EventHandler) {
if (all[type]) {
if (!type) {
all = Object.create(null);
} else if (all[type]) {
all[type].splice(all[type].indexOf(handler) >>> 0, 1);
}
},
Expand Down
22 changes: 22 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,28 @@ describe('mitt#', () => {
expect(events).to.have.property('foo').that.is.empty;
});

it('should remove all handlers when invoked without type', () => {
const onFoo = spy();
const onBar = spy();

inst.on('foo', onFoo);
inst.on('bar', onBar);

inst.emit('foo', 1);
inst.emit('foo', 2);
inst.emit('bar', 3);

inst.off();

inst.emit('foo', 4);
inst.emit('foo', 5);
inst.emit('bar', 6);
inst.emit('bar', 7);

expect(onFoo).to.have.callCount(2);
expect(onBar).to.have.callCount(1);
});

it('should NOT normalize case', () => {
let foo = () => {};
inst.on('FOO', foo);
Expand Down