Conversation
andrewbattat
commented
Mar 26, 2026
andrewbattat
commented
Mar 26, 2026
r-birkner
reviewed
Mar 27, 2026
r-birkner
reviewed
Mar 27, 2026
r-birkner
approved these changes
Mar 30, 2026
Bownairo
reviewed
Mar 30, 2026
basvandijk
approved these changes
Mar 31, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…fetch delegations (#9595) Since non-cloud engine nodes (including nodes of the NNS subnet) deny incoming connections from cloud engine nodes in the firewall, a few adjustments are required. Cloud engines' registry replicators already use API BNs instead of NNS nodes directly. Similarly, this PR makes cloud engine nodes use API BNs instead of NNS nodes to fetch delegations. This PR also extends the current system test on NNS delegations to test all endpoints on all subnet types (including the NNS, which should effectively not return a delegation). Note: we need to wait that #9613 reaches mainnet NNS before re-enabling the mainnet variant of the system test for cloud engines. This is tracked in CON-1696. Another note concerning the introduced dependency `webpki-roots`: this dependency was already used transitively but not directly. We have the choice between using native certs (provided by the OS) or the `webpki-roots` crate which contains a list of CAs maintained by Mozilla. The decision is not new and was already [extensively discussed](4f05450). After discussing with Franz-Stefan, we decided that `webpki-roots` made more sense for the sake of consistency. --------- Co-authored-by: Andrew Battat <andrew.battat@dfinity.org> Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
daniel-wong-dfinity-org
pushed a commit
that referenced
this pull request
Apr 1, 2026
…fetch delegations (#9595) Since non-cloud engine nodes (including nodes of the NNS subnet) deny incoming connections from cloud engine nodes in the firewall, a few adjustments are required. Cloud engines' registry replicators already use API BNs instead of NNS nodes directly. Similarly, this PR makes cloud engine nodes use API BNs instead of NNS nodes to fetch delegations. This PR also extends the current system test on NNS delegations to test all endpoints on all subnet types (including the NNS, which should effectively not return a delegation). Note: we need to wait that #9613 reaches mainnet NNS before re-enabling the mainnet variant of the system test for cloud engines. This is tracked in CON-1696. Another note concerning the introduced dependency `webpki-roots`: this dependency was already used transitively but not directly. We have the choice between using native certs (provided by the OS) or the `webpki-roots` crate which contains a list of CAs maintained by Mozilla. The decision is not new and was already [extensively discussed](4f05450). After discussing with Franz-Stefan, we decided that `webpki-roots` made more sense for the sake of consistency. --------- Co-authored-by: Andrew Battat <andrew.battat@dfinity.org> Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NODE-1921
Add support for API Boundary Nodes to obtain real DNS domains and TLS certificates via Farm's playnet infrastructure. This is needed because Cloud Engines access the IC exclusively through API BNs, and the delegation fetcher verifies TLS certificates -- the previous self-signed certs with bogus domains won't work.