You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I know how to update typings and have done so, or typings don't need updating
This PR includes breaking changes (methods removed or renamed, parameters moved or removed) (Not really sure. Increases the time allowed to establish a connection.)
Merging #8679 (db2e56b) into main (c446a84) will increase coverage by 0.13%.
The diff coverage is 100.00%.
❗ Current head db2e56b differs from pull request most recent head 9ab51b0. Consider uploading reports for the commit 9ab51b0 to get more accurate results
I was surprised it got merged so quickly, I even put that it was likely a breaking change. The real fix is probably waiting for nodejs/node#44731 however.
After revisiting internally, we will likely not revert and monitor the repository for bugs caused by this. The chance of it being faulty is very unlikely. Overall the aforementioned pattern is questionable as a recommendation with the slightest consideration of our general user base, as it will globally alter undici for any requests, not just discord.js specific ones.
Fixing the issue currently at hand also has priority at this moment in time - again, actively watching for bugs/breaking reports for the time being.
Tekks
added a commit
to Tekks/weebly
that referenced
this pull request
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #8629
Fixes #8489
Repeated issue:
I have no way of testing this but 30 seconds seems to work for others.
The issue seems to be with misconfigured ipv6, see nodejs/undici#1531 (comment)
Status and versioning classification: