This repository was archived by the owner on Jan 15, 2024. It is now read-only.
[FEATURE] [WIP] Use softmax with length in attention cells#910
Closed
ptrendx wants to merge 5 commits intodmlc:masterfrom
Closed
[FEATURE] [WIP] Use softmax with length in attention cells#910ptrendx wants to merge 5 commits intodmlc:masterfrom
ptrendx wants to merge 5 commits intodmlc:masterfrom
Conversation
Codecov Report
|
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
===========================================
- Coverage 90.48% 29.21% -61.27%
===========================================
Files 66 66
Lines 6400 6380 -20
===========================================
- Hits 5791 1864 -3927
- Misses 609 4516 +3907
|
6 tasks
Member
|
moved to #1091 for BERT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MXNet added support for softmax with length parameter (apache/mxnet#15169) and this PR attempts to use it in attention cells. Work done by me and @blchu.
@eric-haibin-lin Could you help in making sure this works for all models (we tested just BERT and Transformer decoder)?
Checklist
Essentials