Deprecate extending schema classes#7100
Merged
morozov merged 2 commits intodoctrine:4.4.xfrom Aug 26, 2025
Merged
Conversation
morozov
changed the title
greg0ire
previously approved these changes
Aug 26, 2025
morozov
force-pushed
the
deprecate-extending-schema
branch
from
4a34f72 to
3aa2450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the
Column,ForeignKeyConstraint,IndexandUniqueConstraintclasses soft-marked as@final, I'm marking the rest of schema-related classes as@finalas well. They are value objects and are not meant to be extended.Making them final in 5.0.x will allow to rework their internal implementation w/o breaking BC.