Fix enumType handling in Column

[VincentLanglet]

Q	A
Type	bug
Fixed issues

Summary

cc @morozov since you made #6975 and #6945

With the deprecation/remove of hasPlatformOption/getPlatformOption in favor of specific getter. I feel like some getter (and editor method) are missing. (But maybe I'm misunderstand something ?)

Which means

• a call like $column->getPlatformOption('enumType') has currently no replacement
• editing a column is loosing extra platform options like enumType

The enumType platformOption is set when using something like

#[ORM\Column(name: 'foo', type: Types::STRING, enumType: Foo::class)]

and there is maybe more similar options...

I'm personally implementing a custom lib which requires to access enumType option from a Column and this won't be possible in 5.x without any changes.

[morozov]

@VincentLanglet yes, the support for enumType is indeed missing. While introducing the new API in #6945, I was using ColumnProperties and the test suite as a reference, and neither covered it. Thank you for catching the issue.

[VincentLanglet]

@VincentLanglet yes, the support for enumType is indeed missing. While introducing the new API in #6945, I was using ColumnProperties and the test suite as a reference, and neither covered it. Thank you for catching the issue.

Great. I'm not familiar with this code. Do you think

• There is more to do in this PR ?
• There is other options with the same issues ?

[morozov]

Looks good, just need types documented.

[morozov]

Do you think

• There is more to do in this PR ?
• There is other options with the same issues ?

I don't know. If you look at the usage of Column#$_platformOptions, there is no usage of enumType in the codebase (this must be an ORM addition).

[morozov]

@VincentLanglet please squash the commits. We don't want to see Phpdoc / Fix / Fix in the resulting history.

[VincentLanglet]

@VincentLanglet please squash the commits. We don't want to see Phpdoc / Fix / Fix in the resulting history.

Sure, done.
I'm used to "Squash & Merge".

[morozov]

Thank you, @VincentLanglet.

[VincentLanglet]

Hi, any plan for the 4.4.2 release ? :)

[derrabus]

Here you go: https://github.com/doctrine/dbal/releases/tag/4.4.2