Catch mysqli_sql_exception from mysqli::begin_transaction()#7276
Merged
morozov merged 1 commit intodoctrine:4.4.xfrom Jan 18, 2026
Merged
Catch mysqli_sql_exception from mysqli::begin_transaction()#7276morozov merged 1 commit intodoctrine:4.4.xfrom
morozov merged 1 commit intodoctrine:4.4.xfrom
Conversation
greg0ire
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing test started failing with the releases of PHP 8.5.2, PHP 8.4.17 and PHP 8.3.30 (php/php-src@dbf56e0) (example):
The proposed logic is consistent with
commit()androllBack(), however I don't know if handling the return value is still needed.UPD: starting PHP 8.1.0, the default mysqli error reporting mode is
MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT(documentation), which means throwing amysqli_sql_exceptionfor errors from mysqli function calls (documentation).Since we require PHP ~8.2, it means that we no longer need to check the return value. The code could be cleaned up in the next minor release.