Avoid mocks without expectations#7306
Merged
derrabus merged 1 commit intodoctrine:4.4.xfrom Feb 5, 2026
Merged
Conversation
greg0ire
approved these changes
Feb 4, 2026
morozov
approved these changes
Feb 4, 2026
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Feb 5, 2026
* 4.4.x: Avoid mocks without expectations (doctrine#7306)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Feb 5, 2026
* 4.5.x: Avoid mocks without expectations (doctrine#7306)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHPUnit 12.5 triggers a notice if we create a mock object and don't configure any expectations on that object. A stub would suffice in that case. This PR is a first step towards separating mocks and stubs. It fixes all easy picks that I could find.
Some of our tests created mocks of the
DateTimeImmutableclass. I don't find that very reasonable, so I converted those mocks to actualDateTimeImmutableinstances.