Skip to content

review feedback

e8df89e
Select commit
Loading
Failed to load commit list.
Merged

Improve async string perf and fix reading chars with initial offset. #3377

review feedback
e8df89e
Select commit
Loading
Failed to load commit list.
Azure Pipelines / CI-SqlClient succeeded Jun 2, 2025 in 1h 10m 47s

Build #15301 had test failures

Details

Tests

  • Failed: 1 (0.00%)
  • Passed: 105,141 (96.81%)
  • Other: 3,459 (3.19%)
  • Total: 108,601
Code coverage

  • 88708 of 136292 line covered (65.09%)

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0

EXEC(0,0): Error Message: 

Check failure on line 257 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

build.proj#L257

build.proj(257,5): Error MSB3073: The command "         dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj"         --no-build         -v n         -p:Configuration=Release         -p:TargetnetcoreVersion=net8.0         -p:ReferenceType=Project         -p:TestSet=3         -p:TestTargetOS=Windowsnetcoreapp         --collect "Code coverage"         --results-directory TestResults         --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests"         --logger:"trx;LogFilePrefix=Manual-Windowsnetcoreapp-3"       " exited with code 1.

Check failure on line 728 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Build log #L728

Process 'msbuild.exe' exited with code '1'.

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0

EXEC(0,0): Error Message: 

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.WeakRefTestYukonSpecific.TestReaderMars

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.WeakRefTestYukonSpecific.TestReaderMars

Microsoft.Data.SqlClient.SqlException : The connection is broken and recovery is not possible.  The connection is marked by the client driver as unrecoverable.  No attempt was made to restore the connection.
Raw output
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 2182
   at Microsoft.Data.SqlClient.SqlConnection.ValidateAndReconnect(Action beforeDisconnect, Int32 timeout) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1601
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs:line 4980
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs:line 4857
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs:line 4738
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs:line 2090
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader() in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs:line 2063
   at Microsoft.Data.SqlClient.ManualTesting.Tests.WeakRefTestYukonSpecific.OpenNullifyReader(SqlCommand command) in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/WeakRefTestYukonSpecific/WeakRefTestYukonSpecific.cs:line 193
   at Microsoft.Data.SqlClient.ManualTesting.Tests.WeakRefTestYukonSpecific.TestReaderMarsCase(String caseName, String connectionString, ReaderTestType testType, ReaderVerificationType verificationType, String methodName) in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/WeakRefTestYukonSpecific/WeakRefTestYukonSpecific.cs:line 133
   at Microsoft.Data.SqlClient.ManualTesting.Tests.WeakRefTestYukonSpecific.TestReaderMars() in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/WeakRefTestYukonSpecific/WeakRefTestYukonSpecific.cs:line 33
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)