Skip to content

Tests | ActiveIssues (Part 4)#3750

Merged
benrr101 merged 16 commits intomainfrom
dev/russellben/active-issues4
Nov 20, 2025
Merged

Tests | ActiveIssues (Part 4)#3750
benrr101 merged 16 commits intomainfrom
dev/russellben/active-issues4

Conversation

@benrr101
Copy link
Copy Markdown
Contributor

@benrr101 benrr101 commented Nov 6, 2025 •
edited
Loading

Description

This PR enables another set of tests that were previously marked as [ActiveIssue]. The active issue numbers predate our Github repository, so I cannot really know why the tests were disabled in the first place. And may of them ... just work with no modifications. Here's a rundown of the changes:

  • Enable tests in SqlCommandCancelTest
    • TimeoutCancel (renamed TimeoutCancelTcp to differentiate)
    • TimeoutCancelNP (renamed TimeoutCancelNamedPipe)
    • TimeOutDuringRead (renamed TimeoutDuringReadTcp)
    • TimeOutDuringReadNP (renamed TimeoutDuringReadNamedPipe)
    • Rewrote the Timeout test method to use less custom helpers to make it easier to diagnose CI failures
  • Enable tests in SqlCredentialTest
    • SqlConnectionChangePasswordPlaintext - no changes, it just worked
    • SqlConnectionChangePasswordSecureString - no changes, it just worked
    • Some light cleanup of SqlCredentialTest
      • Make some strings constants
      • Rename methods to match naming conventions
      • Use keyword type names for built-ins
  • Rewrite MARSSessionPoolingTest
    • Split big bulky "one stop shop" test method into many separate tests
    • Separated tests are based on matrix of scenarios and expected behavior
    • Introduce back-off of DMV query to verify expected session and request count
    • MARSSessionPoolingTest => MarsSessionPoolingTest

Issues

Separation of work from #3012, and investigation towards #3682

Testing

  • Reactivated tests were tested locally and pass
  • MARS tests were thoroughly ran and potential flakiness has been resolved

benrr101 added 10 commits November 5, 2025 13:34
@benrr101
Reenable tests in SqlCommandCancelTest: TimeoutCancelTcp, TimeoutCanc…
d543a1b 
…elNamedPipe, TimeoutDuringReadTcp, TimeoutDuringReadNamedPipe
@benrr101
Reenable tests in SqlCredentialTest - SqlConnectionChangePasswordPlai…
cafa83b 
…ntext, SqlConnectionChangePasswordSecureString
@benrr101
Very light cleanup of SqlCredentialTest
b5dd2fe
@benrr101
Reenable MarsSessionPoolingTest in MarsExecuteReader_Text_WithGC and …
0815d29 
…MarsExecuteReader_StoredProcedure_WithGC

# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MARSSessionPoolingTest.cs
@benrr101
Split tests into separate tests for each scenario, discover which tes…
317f456 
…ts are flaky
@benrr101
Mostly working . Except for those no close tests
20f46f7
@benrr101
Clean up old code, but the nocloses test still breaks everything - ne…
c1f9ac1 
…ed to investigate if it's a bug
@benrr101
Clean up a biiiit more
814736f
@benrr101
Finishing test matrix, improving DisposableArray, renaming test file …
d2a7930 
…to match guidelines
@benrr101
Final iteration of tests, adding backoff to DMV queries, adding #null…
099bc0b 
…able enable
@benrr101 benrr101 added this to the 7.0.0-preview3 milestone Nov 6, 2025
@benrr101 benrr101 requested a review from a team as a code owner November 6, 2025 22:22
Copilot AI review requested due to automatic review settings November 6, 2025 22:22
@benrr101 benrr101 added the Area\Tests Issues that are targeted to tests or test projects label Nov 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Nov 6, 2025
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors MARS (Multiple Active Result Sets) session pooling tests and fixes several test-related issues. The main focus is on rewriting the MARS session pooling tests to be more maintainable and clearer, while also fixing various test issues across multiple test files.

  • Rewrites MARS session pooling tests with improved structure and clarity
  • Removes [ActiveIssue] attributes from tests that have been fixed
  • Improves naming conventions in test methods and helper utilities

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MarsSessionPoolingTest.cs Complete rewrite of MARS session pooling tests with improved test organization and clarity
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MARSSessionPoolingTest.cs Deleted old MARS session pooling test file
src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj Updated file reference to match new casing
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCredentialTest/SqlCredentialTest.cs Improved code quality: made password strings const, renamed helper methods to PascalCase, changed String to string, removed fixed ActiveIssue attributes
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCancelTest.cs Renamed test methods for clarity and removed fixed ActiveIssue attributes
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Added helper method combining connection string and Synapse checks
src/Microsoft.Data.SqlClient/tests/Common/DisposableArray.cs Added new utility class for managing disposable arrays

@paulmedynski paulmedynski self-assigned this Nov 7, 2025
paulmedynski
paulmedynski requested changes Nov 7, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings November 7, 2025 17:45
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

paulmedynski
paulmedynski previously approved these changes Nov 7, 2025
View reviewed changes
paulmedynski
paulmedynski previously approved these changes Nov 11, 2025
View reviewed changes
mdaigle
mdaigle requested changes Nov 11, 2025
View reviewed changes
@benrr101
Remove AreConnStringsNotAzureSynapse
27e9f3d 
Adding doc comments to DisposableArray
Copilot AI review requested due to automatic review settings November 11, 2025 23:52
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Nov 17, 2025
@benrr101 benrr101 merged commit a65b8a4 into main Nov 20, 2025
507 of 509 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Nov 20, 2025
@benrr101 benrr101 deleted the dev/russellben/active-issues4 branch November 20, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mdaigle mdaigle mdaigle approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

Assignees

@paulmedynski paulmedynski

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

SqlClient Board
Status: Done

Milestone

7.0.0-preview3

Development

Successfully merging this pull request may close these issues.

5 participants

@benrr101 @mdaigle @paulmedynski @cheenamalhotra