Add support for extra Docker build options#2063
Conversation
|
Your description makes it sound like we had set a custom ulimit before, was that from a different extension point or in the base VM image? |
lbussell
left a comment
lbussell
left a comment
There was a problem hiding this comment.
Changes look OK to me, please add a brief description to eng/docker-tools/CHANGELOG.md.
it wasn't needed when we were running on the ubuntu image for some reason. After switching to the azurelinux one it started being a problem. Premek was able to verify this in https://dev.azure.com/dnceng/internal/_build/results?buildId=2942140&view=results |
|
Premek is oof today and on Monday, I opened up #2064 with the added change logs. I couldn't push to his fork |
|
Superseded by #2064 |
Ports #2063 to my fork since I don't have access to Premeks --------- Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: Logan Bussell <loganbussell@microsoft.com>
3 participants
We will need to pass
--ulimit nofile=65536:65536to thedocker buildcommanddotnet/dotnet-buildtools-prereqs-docker#1621 (comment)