Task completion and exception handling#53005
Draft
BillWagner wants to merge 1 commit intodotnet:mainfrom
Draft
Conversation
1. Create `task-exception-handling.md` — from "Task exception handling in .NET 4.5." Covers `GetAwaiter().GetResult()` vs `.Result` exception propagation, `AggregateException` unwrapping, unobserved task exceptions, `TaskScheduler.UnobservedTaskException`. **Update:** modern .NET default behavior (unobserved exceptions no longer crash the process). 1. Create `complete-your-tasks.md` — from "Don't forget to complete your tasks." Covers: always complete `TaskCompletionSource` on all paths, common bugs (forgetting `SetException` in catch, dropping `TaskCompletionSource` references during reset). 1. Incorporate FAQ content about `Task.Result` vs `GetAwaiter().GetResult()`. 1. Add both to TOC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task-exception-handling.md— from "Task exception handling in .NET 4.5." CoversGetAwaiter().GetResult()vs.Resultexception propagation,AggregateExceptionunwrapping, unobserved task exceptions,TaskScheduler.UnobservedTaskException. Update: modern .NET default behavior (unobserved exceptions no longer crash the process).complete-your-tasks.md— from "Don't forget to complete your tasks." Covers: always completeTaskCompletionSourceon all paths, common bugs (forgettingSetExceptionin catch, droppingTaskCompletionSourcereferences during reset).Task.ResultvsGetAwaiter().GetResult().Internal previews