Skip to content

TarReader: implement GNU sparse format 1.0 (PAX) #125283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 40 commits into from
Apr 9, 2026
Merged

TarReader: implement GNU sparse format 1.0 (PAX) #125283

Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
e609249
Initial plan
Copilot Mar 6, 2026
543c8f2
Fix TarReader to handle GNU sparse format 1.0 (PAX) - resolve GNU.spa…
Copilot Mar 6, 2026
351d885
Fix copy constructor to propagate _gnuSparseRealSize; improve test as…
Copilot Mar 6, 2026
cd7c720
Merge branch 'main' into copilot/fix-gnu-sparse-format-handling
lewing Mar 9, 2026
5db74bb
Implement full GNU sparse format 1.0 PAX DataStream expansion via Gnu…
Copilot Mar 9, 2026
1015043
Fix GnuSparseStream: add MaxSparseSegments DoS limit, precompute pack…
Copilot Mar 9, 2026
c34240f
Address reviewer feedback: simplify error strings, minor=0 check, typ…
Copilot Mar 10, 2026
583239c
Address remaining reviewer feedback: group sparse attrs, IndexOf-base…
Copilot Mar 10, 2026
498e3e9
Move sparse tests to TarReader.SparseFile.Tests.cs, add corrupted for…
Copilot Mar 10, 2026
fc05df3
Address review: merge sync/async ParseSparseMap, 1024-byte buffer, Ut…
Copilot Mar 10, 2026
24f0fb3
Fix TarReader: implement full GNU sparse format 1.0 (PAX) reading wit…
Copilot Mar 10, 2026
91213c7
Merge remote-tracking branch 'upstream/main' into copilot/fix-gnu-spa…
rzikm Mar 10, 2026
d656d45
Move async sparse tests to TarReader.SparseFile.Tests.cs
rzikm Mar 10, 2026
24e7e62
Fix buffer overflow in ParseSparseMap for long malformed lines
rzikm Mar 10, 2026
f78a16e
Add test: copy sparse entry to new archive preserves expanded content
rzikm Mar 10, 2026
87212d5
Refactor: separate _gnuSparseDataStream from _dataStream, simplify Re…
rzikm Mar 10, 2026
35a72b9
Fix ReadFromPackedData positioning and add copy round-trip test
rzikm Mar 10, 2026
e1fed30
Merge remote-tracking branch 'origin/main' into copilot/fix-gnu-spars…
Copilot Mar 10, 2026
48132ab
Merge latest main, add archive size assert in test, fix FindSegmentFr…
Copilot Mar 10, 2026
e4a2b76
Defer sparse map parsing to first Read for non-seekable stream support
rzikm Mar 11, 2026
451f9e0
Add non-seekable source tests for sparse entry copy round-trip
rzikm Mar 11, 2026
df76255
Verify archive size when copying
rzikm Mar 11, 2026
26cb2ca
Consolidate sparse layout tests into single parameterized test
rzikm Mar 11, 2026
feed417
Deduplicate some tests
rzikm Mar 11, 2026
482b139
Deduplicate remaining sparse tests
rzikm Mar 11, 2026
3e41073
Address code review: remove unused _dataStart, add overflow check, fi…
rzikm Mar 11, 2026
6cdfd74
Use ArrayPool for ParseSparseMap buffer
rzikm Mar 11, 2026
313d905
Validate sparse map segment ordering and bounds
rzikm Mar 11, 2026
2d25c96
Use MemberData for corrupted sparse map tests, exercise all cases syn…
rzikm Mar 11, 2026
d02aec5
Address review: dispose raw stream, check skipBytes, fix async Advanc…
rzikm Mar 16, 2026
dfedc9a
Merge remote-tracking branch 'upstream/main' into copilot/fix-gnu-spa…
rzikm Mar 16, 2026
cddc9d0
Don't dispose multiple times
rzikm Mar 16, 2026
6967f5f
Fix segment search: binary search for backward seeks, preserve sequen…
Copilot Mar 18, 2026
d79a6df
Throw on negative GNU.sparse.realsize, add DisposeAsync to GnuSparseS…
Copilot Mar 23, 2026
b84409a
Reduce test code duplication: extract WriteSparseEntry helper, refact…
Copilot Mar 24, 2026
95cf623
Merge branch 'main' into copilot/fix-gnu-sparse-format-handling
rzikm Apr 1, 2026
d35983c
Fix failing tests: replace non-existent golang_tar files with program…
Copilot Apr 2, 2026
c56965e
Fix NegativeSparseRealSize_InvalidDataException test: inject realsize…
Copilot Apr 2, 2026
74bd575
Fix invalid cast in WriteSparseEntry: use reflection to inject GNU.sp…
Copilot Apr 8, 2026
1f680f2
Revert "Fix failing tests: replace non-existent golang_tar files with…
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
<Compile Include="System\Formats\Tar\TarWriterOptions.cs" />
<Compile Include="System\Formats\Tar\SubReadStream.cs" />
<Compile Include="System\Formats\Tar\SeekableSubReadStream.cs" />
<Compile Include="System\Formats\Tar\GnuSparseStream.cs" />
<Compile Include="$(CommonPath)DisableRuntimeMarshalling.cs" Link="Common\DisableRuntimeMarshalling.cs" />
<Compile Include="$(CommonPath)System\IO\Archiving.Utils.cs" Link="Common\System\IO\Archiving.Utils.cs" />
<Compile Include="$(CommonPath)System\IO\PathInternal.cs" Link="Common\System\IO\PathInternal.cs" />
Expand Down
Loading
Loading