[RISC-V] Support displaying GTF_ADDRMODE_NO_CSE flag on GT_CAST#125516
[RISC-V] Support displaying GTF_ADDRMODE_NO_CSE flag on GT_CAST#125516namu-lee wants to merge 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull request overview
Updates CoreCLR JIT tree dumping so nodes marked with GTF_ADDRMODE_NO_CSE display as GTF_DONT_CSE (intended to help diagnose complex addressing-mode patterns, including those involving casts).
Changes:
- Extends the
gtDispNodeflag printing logic to includeGT_CASTwhen deciding to displayGTF_ADDRMODE_NO_CSEasGTF_DONT_CSE.
You can also share your feedback on Copilot code review. Take the survey.
2ffd698 to
5c49e6d
Compare
There was a problem hiding this comment.
Pull request overview
Updates CoreCLR JIT tree dump formatting to better reflect address-mode-related “no CSE” markings, including when they occur on cast nodes.
Changes:
- Extend
gtDispNode’s flag-printing logic to considerIsPartOfAddressMode()nodes. - Treat
GT_CASTsimilarly toGT_ADD/GT_MUL/GT_LSHfor displaying theGTF_ADDRMODE_NO_CSEintent (printed asGTF_DONT_CSE).
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR refactors JIT tree debug flag printing in Compiler::gtDispNode to use the existing GenTree::IsPartOfAddressMode() helper when deciding to display GTF_ADDRMODE_NO_CSE-marked nodes as GTF_DONT_CSE. This keeps address-mode-related behavior consistent with other parts of the JIT that already use IsPartOfAddressMode().
Changes:
- Replace inline operator checks (
GT_ADD/GT_MUL/GT_LSH+GTF_ADDRMODE_NO_CSE) withtree->IsPartOfAddressMode(). - Preserve existing behavior for clearing
GTF_REVERSE_OPSon non-binary/non-multiop nodes, while making the control flow slightly more direct.
You can also share your feedback on Copilot code review. Take the survey.
|
@namu-lee, please address test failures and convert this PR back when it is ready for review. |
|
Test failures were presumably CI issues, going to rerun CI |
Follow-up to #122088.
Add support to display the
GTF_ADDRMODE_NO_CSEflag onGT_CAST.Before
After
Part of #84834, cc @dotnet/samsung