Skip to content

Fix for arm64 outerloop jitstress failures in FMA #126434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhartglassMSFT merged 2 commits into from
Apr 7, 2026
+11 −3
Merged

Fix for arm64 outerloop jitstress failures in FMA #126434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37cbb1
initial impl
dhartglassMSFT Apr 1, 2026
833a03b
jitformat
dhartglassMSFT Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,8 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
{
case 2:
{
assert(!isRMW);

HWIntrinsicImmOpHelper helper(this, intrin.op2, node);

for (helper.EmitBegin(); !helper.Done(); helper.EmitCaseEnd())
Expand All @@ -454,6 +456,8 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)

case 3:
{
assert(!isRMW);

HWIntrinsicImmOpHelper helper(this, intrin.op3, node);

for (helper.EmitBegin(); !helper.Done(); helper.EmitCaseEnd())
Expand All @@ -469,7 +473,10 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
{
assert(isRMW);

HWIntrinsicImmOpHelper helper(this, intrin.op4, node);
// emitIns_R_R_R_R_I may emit a mov (when not redundant) for RMW instructions;
// the ImmOpHelper must account for that mov
int numInstrs = (targetReg != op1Reg) ? 2 : 1;
Comment thread
dhartglassMSFT marked this conversation as resolved.
HWIntrinsicImmOpHelper helper(this, intrin.op4, node, numInstrs);

for (helper.EmitBegin(); !helper.Done(); helper.EmitCaseEnd())
{
Expand Down Expand Up @@ -499,8 +506,9 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
{
assert(hasImmediateOperand);

GenTree* shiftOp = isRMW ? intrin.op3 : intrin.op2;
HWIntrinsicImmOpHelper helper(this, shiftOp, node);
GenTree* shiftOp = isRMW ? intrin.op3 : intrin.op2;
int numInstrs = (isRMW && (targetReg != op1Reg)) ? 2 : 1;
HWIntrinsicImmOpHelper helper(this, shiftOp, node, numInstrs);

for (helper.EmitBegin(); !helper.Done(); helper.EmitCaseEnd())
{
Expand Down
Loading