[cDAC] Implement SetJITCompilerFlags for cDAC#126595
Open
barosiak wants to merge 7 commits intodotnet:mainfrom
Open
[cDAC] Implement SetJITCompilerFlags for cDAC#126595barosiak wants to merge 7 commits intodotnet:mainfrom
barosiak wants to merge 7 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements IXCLRDataModule2.SetJITCompilerFlags for the managed cDAC by wiring it to the Loader contract’s module transient-flag debugger bits, adding the necessary contract surface and tests to validate read/write behavior.
Changes:
- Implement
IXCLRDataModule2.SetJITCompilerFlagsinClrDataModuleby updating module debugger control bits viaILoader. - Extend
ILoader/Loader_1withGetDebuggerInfoBitsandSetDebuggerInfoBits, and document the new contract surface/constants. - Update cDAC test infrastructure to support target-memory writes and add Loader tests for debugger-bit get/set and flag preservation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs | Implements SetJITCompilerFlags using Loader debugger-info bits. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs | Adds managed DebuggerAssemblyControlFlags enum mirroring cordbpriv.h. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs | Adds GetDebuggerInfoBits / SetDebuggerInfoBits to the Loader contract. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs | Implements debugger-info bit get/set by reading/writing Module::Flags. |
| src/native/managed/cdac/tests/TestPlaceholderTarget.cs | Adds write-capable target support for tests. |
| src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Loader.cs | Allows initializing module transient flags in mocks. |
| src/native/managed/cdac/tests/LoaderTests.cs | Adds new tests for debugger-info bit behavior. |
| docs/design/datacontracts/Loader.md | Documents new Loader contract methods and constants. |
| src/coreclr/vm/ceeload.h | Notes cDAC Loader contract dependency on debugger-info mask/shift constants. |
| src/coreclr/inc/cordbpriv.h | Adds explicit comment that cDAC depends on flag values. |
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs
Show resolved
Hide resolved
noahfalk
reviewed
Apr 8, 2026
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs
Outdated
Show resolved
Hide resolved
max-charlamb
reviewed
Apr 8, 2026
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
rcj1
reviewed
Apr 10, 2026
rcj1
reviewed
Apr 10, 2026
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
rcj1
reviewed
Apr 10, 2026
barosiak
requested review from
BrzVlad,
MichalStrehovsky,
akoeplinger,
janvorli,
kg,
maraf,
sbomer,
steveisok,
thaystg and
vitek-karas
as code owners
barosiak
force-pushed
the
barosiak/SetJITCompilerFlags
branch
from
f37b5e7 to
d0c1fe4
Compare
max-charlamb
added
area-Diagnostics-cdac
and removed
area-Diagnostics-coreclr
linkable-framework
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
janvorli
reviewed
Apr 13, 2026
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/EEConfig.cs
Outdated
Show resolved
Hide resolved
...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
SetJITCompilerFlagsonIXCLRDataModule2in the cDAC. Changes
SetJITCompilerFlagsimplementation