Backtick 'value' keyword in from_json struct type definitions#249
Merged
gauravdawar-e6 merged 1 commit intoe6data:mainfrom Apr 3, 2026
Merged
Conversation
In from_json, if the schema Literal contains 'value:' as a field name, backtick it to '`value`:' since value is a reserved keyword in the E6 engine's struct type parser. Does not affect valueKey, valueOf, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_json(), the schema string'struct<value: string>'needsvaluebackticked as`value`since it's a reserved keyword in the E6 engine's struct type parseranonymous_sql— when the function isfrom_json, checks each Literal argument forvalue:and replaces with`value`:valueKey,valueOf, etc. sincereplace("value:", ...)only matches the exact substringTest plan
struct<value: string, valueKey: string>→struct<value: string, valueKey: string>