Skip to content

Add automatic module name#3401

Merged
vietj merged 1 commit intoeclipse-vertx:masterfrom
afloarea:automatic-module-name
May 14, 2020
Merged

Add automatic module name#3401
vietj merged 1 commit intoeclipse-vertx:masterfrom
afloarea:automatic-module-name

Conversation

@afloarea
Copy link
Copy Markdown
Contributor

@afloarea afloarea commented May 6, 2020

Signed-off-by: afloarea adrianfloarea07@yahoo.com

Motivation:

Add automatic module name as per issue #524

@vietj
Copy link
Copy Markdown
Member

vietj commented May 7, 2020

I woiuld like first to see if we can do something in the vertx-parent pom

@vietj
Copy link
Copy Markdown
Member

vietj commented May 7, 2020

@afloarea please have a look at vert-x3/vertx-parent@1384372

This change should allow to have a file named MANIFEST.MF that will contain the entry containing Automatic-Module-Name: io.vertx.core that will define the automatic module name.

Signed-off-by: afloarea <adrianfloarea07@yahoo.com>
@vietj vietj merged commit 22ce191 into eclipse-vertx:master May 14, 2020
@vietj vietj added this to the 4.0.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants