Add automatic module name#302
Merged
vietj merged 1 commit intoeclipse-vertx:masterfrom May 22, 2020
afloarea:automatic-module-name
Merged
Add automatic module name#302vietj merged 1 commit intoeclipse-vertx:masterfrom afloarea:automatic-module-name
vietj merged 1 commit intoeclipse-vertx:masterfrom
afloarea:automatic-module-name
Conversation
Signed-off-by: afloarea <adrianfloarea07@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: afloarea adrianfloarea07@yahoo.com
Motivation:
Add automatic module name as per vert-x3/issues#524
Note: The codegen build config is a bit more complex and it uses the assembly plugin. As such, the parent pom could not be used directly. Only the vertx-codegen artifact has an automatic module name.
The vertx codegen processor and tck jars do not have automatic module names.