Increase test coverage - take 2#1012
Merged
yeraydiazdiaz merged 6 commits intoencode:masterfrom Jun 2, 2020
Merged
Conversation
jcugat
commented
May 31, 2020
jcugat
commented
May 31, 2020
jcugat
commented
May 31, 2020
jcugat
commented
May 31, 2020
jcugat
commented
May 31, 2020
yeraydiazdiaz
approved these changes
Jun 1, 2020
Contributor
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
Hey, thanks for your work on this, nice job 💯
The only other usage is from the api.stream method but that is always called from a sync context, so the aexit will never have close_client=True. Should it be removed?
I would say so, seems like dead code.
Left a few suggestions on your comments but in general LGTM 👍
Contributor
|
Fantastic work, thanks so much! Going to leave this one with @yeraydiazdiaz since he's got a better handle on it, but tested locally and looking really nice. Will try to help with the follow-up once it's in. |
It's never set as True when used in async
jcugat
commented
Jun 1, 2020
yeraydiazdiaz
approved these changes
Jun 2, 2020
Contributor
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
This looks great. Thanks @jcugat 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More work towards #316, continuation of #1003
After this is merged, the only remaining untested part will be
URLLib3Transport.Small note about
StreamContextManager. The only line not tested is because the only usage of the context manager in an async environment is from BaseClient.stream where it doesn't use theclose_clientparameter (and by default isfalse). The only other usage is from the api.stream method but that is always called from a sync context, so the__aexit__will never haveclose_client=True. Should it be removed?