Skip to content

Add support for python 3.14#12450

Merged
eivindjahren merged 2 commits intoequinor:mainfrom
eivindjahren:add_3.14
Mar 9, 2026
Merged

Add support for python 3.14#12450
eivindjahren merged 2 commits intoequinor:mainfrom
eivindjahren:add_3.14

Conversation

@eivindjahren
Copy link
Copy Markdown
Contributor

@eivindjahren eivindjahren commented Dec 4, 2025

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 4, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (d75b9bd) to head (f5732ac).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12450      +/-   ##
==========================================
+ Coverage   90.55%   90.62%   +0.07%     
==========================================
  Files         454      454              
  Lines       31233    31230       -3     
==========================================
+ Hits        28282    28303      +21     
+ Misses       2951     2927      -24     
Flag Coverage Δ
cli-tests 37.27% <ø> (+<0.01%) ⬆️
gui-tests 68.14% <ø> (+0.14%) ⬆️
performance-and-unit-tests 77.20% <ø> (+0.07%) ⬆️
test 46.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj
Copy link
Copy Markdown
Collaborator

larsevj commented Mar 3, 2026

I believe this one should be doable now.

@eivindjahren
Copy link
Copy Markdown
Contributor Author

I believe this one should be doable now.

@larsevj We need py314 builds for carolina first:

hint: You're using CPython 3.14 (`cp314`), but `carolina` (v2.0.2) only has wheels with the following Python ABI tags: `cp311`, `cp312`, `cp313`

That is probably not going to be easy, but you are welcome to try.

@larsevj
Copy link
Copy Markdown
Collaborator

larsevj commented Mar 3, 2026

I believe this one should be doable now.

@larsevj We need py314 builds for carolina first:

hint: You're using CPython 3.14 (`cp314`), but `carolina` (v2.0.2) only has wheels with the following Python ABI tags: `cp311`, `cp312`, `cp313`

That is probably not going to be easy, but you are welcome to try.

I see, will give it a try 😄

@larsevj
Copy link
Copy Markdown
Collaborator

larsevj commented Mar 6, 2026

Python 3.14 wheels are available with the latest carolina release now.

@eivindjahren eivindjahren force-pushed the add_3.14 branch 3 times, most recently from e340387 to 7ce7ea8 Compare March 6, 2026 10:21
@eivindjahren
Copy link
Copy Markdown
Contributor Author

@larsevj Builds now but seems to consistently fail the following test:

FAILED tests/ert/unit_tests/services/test_ert_server.py::test_that_connect_logs_permission_error - TimeoutError: Server not started

@larsevj
Copy link
Copy Markdown
Collaborator

larsevj commented Mar 6, 2026

Believe it is pathlib.Path.exists() that no longer raises PermissionError on python3.14, see: python/cpython#118243

@eivindjahren
Copy link
Copy Markdown
Contributor Author

Believe it is pathlib.Path.exists() that no longer raises PermissionError on python3.14, see: python/cpython#118243

Then I think it would be correct to skip the test on 3.14.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 9, 2026

Merging this PR will not alter performance

✅ 35 untouched benchmarks


Comparing eivindjahren:add_3.14 (f5732ac) with main (59c6655)

Open in CodSpeed

Copy link
Copy Markdown
Collaborator

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eivindjahren eivindjahren merged commit 89474d3 into equinor:main Mar 9, 2026
41 checks passed
@eivindjahren eivindjahren deleted the add_3.14 branch March 9, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:maintenance Automatically categorise as maintenance change in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants